Skip to content

Fix indent for returned/thrown/wrapped in parentheses objects in generated js code#6746

Merged
cknitt merged 5 commits into
rescript-lang:masterfrom
DZakh-forks:fix-generated-object-ident
Apr 28, 2024
Merged

Fix indent for returned/thrown/wrapped in parentheses objects in generated js code#6746
cknitt merged 5 commits into
rescript-lang:masterfrom
DZakh-forks:fix-generated-object-ident

Conversation

@DZakh

@DZakh DZakh commented Apr 28, 2024

Copy link
Copy Markdown
Member

No description provided.

@cknitt cknitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! 👍

Not sure if there might be any conflicts with #6102 in the JS output? Let's get that one merged first maybe.

@DZakh

DZakh commented Apr 28, 2024

Copy link
Copy Markdown
Member Author

It's just a matter of running make test after merging changes. I have another pr prepared, so I'd like to have this merged

@cknitt

cknitt commented Apr 28, 2024

Copy link
Copy Markdown
Member

Ok, then let's merge this one first (can't wait for the next one 😄).

@cknitt cknitt merged commit 4738476 into rescript-lang:master Apr 28, 2024
@DZakh

DZakh commented Apr 28, 2024

Copy link
Copy Markdown
Member Author

There is more indent clean up. I'll prepare a pr when I'm back home 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants