Skip to content

feat(batch): reflect tags in batch send#79

Closed
cpenned wants to merge 3 commits into
mainfrom
cursor/batch-schedule-tags-attachments-c357
Closed

feat(batch): reflect tags in batch send#79
cpenned wants to merge 3 commits into
mainfrom
cursor/batch-schedule-tags-attachments-c357

Conversation

@cpenned

@cpenned cpenned commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

The batch send API supports tags on each email in the batch. This crate already exposes tags on CreateEmailBaseOptions, which batch send uses — this change documents that and adds coverage.

Changes

  • Document batch support for tags on BatchSvc::send
  • Add a serialization unit test asserting the batch payload includes tags
  • Add an integration test for batch sends with tags
  • Changelog entry under Unreleased
Open in Web Open in Cursor 

Summary by cubic

Documented and tested batch send support for per-email tags. Updated docs to state that batch supports tags only and not attachments or scheduled_at, removing a CreateEmailBaseOptions link that implied otherwise.

  • Added unit and integration tests to verify tag serialization in batch sends.

Written for commit bfdb267. Summary will update on new commits.

Review in cubic

Batch send already serializes these fields via CreateEmailBaseOptions.
Add integration tests and docs to reflect the updated batch API schema.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Jul 10, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Documentation and test-only changes for batch send fields (scheduled_at, tags, attachments). No production code logic changes.

Re-trigger cubic

Attachments and scheduled_at are not supported on the batch endpoint.
Remove related tests and docs added in the previous revision.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>
@cursor cursor Bot changed the title feat(batch): reflect scheduled_at, tags, and attachments in batch send feat(batch): reflect tags in batch send Jul 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/batch.rs">

<violation number="1" location="src/batch.rs:23">
P3: Users can still infer from this `CreateEmailBaseOptions` documentation that all of the shared send-email fields work in a batch, including `attachments` and `scheduled_at`, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/batch.rs
Comment on lines +23 to +24
/// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to
/// the other send-email body parameters.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Users can still infer from this CreateEmailBaseOptions documentation that all of the shared send-email fields work in a batch, including attachments and scheduled_at, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/batch.rs, line 23:

<comment>Users can still infer from this `CreateEmailBaseOptions` documentation that all of the shared send-email fields work in a batch, including `attachments` and `scheduled_at`, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.</comment>

<file context>
@@ -20,8 +20,8 @@ impl BatchSvc {
     ///
-    /// Each [`CreateEmailBaseOptions`] in the batch supports `scheduled_at`, `tags`,
-    /// and `attachments`, in addition to the other send-email body parameters.
+    /// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to
+    /// the other send-email body parameters.
     ///
</file context>
Suggested change
/// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to
/// the other send-email body parameters.
/// Batch sends support `tags` on each [`CreateEmailBaseOptions`]. The
/// `attachments` and `scheduled_at` fields are not supported.

@cubic-dev-ai
cubic-dev-ai Bot dismissed their stale review July 13, 2026 16:20

Dismissed because Cubic found issues in a newer review.

Avoid implying all send-email fields, such as attachments, apply to batch.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

@cpenned cpenned closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants