feat(batch): reflect tags in batch send#79
Conversation
Batch send already serializes these fields via CreateEmailBaseOptions. Add integration tests and docs to reflect the updated batch API schema. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Documentation and test-only changes for batch send fields (scheduled_at, tags, attachments). No production code logic changes.
Re-trigger cubic
Attachments and scheduled_at are not supported on the batch endpoint. Remove related tests and docs added in the previous revision. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/batch.rs">
<violation number="1" location="src/batch.rs:23">
P3: Users can still infer from this `CreateEmailBaseOptions` documentation that all of the shared send-email fields work in a batch, including `attachments` and `scheduled_at`, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| /// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to | ||
| /// the other send-email body parameters. |
There was a problem hiding this comment.
P3: Users can still infer from this CreateEmailBaseOptions documentation that all of the shared send-email fields work in a batch, including attachments and scheduled_at, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/batch.rs, line 23:
<comment>Users can still infer from this `CreateEmailBaseOptions` documentation that all of the shared send-email fields work in a batch, including `attachments` and `scheduled_at`, even though the batch endpoint rejects or ignores them. A concise limitation note here would prevent misuse of the shared builder.</comment>
<file context>
@@ -20,8 +20,8 @@ impl BatchSvc {
///
- /// Each [`CreateEmailBaseOptions`] in the batch supports `scheduled_at`, `tags`,
- /// and `attachments`, in addition to the other send-email body parameters.
+ /// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to
+ /// the other send-email body parameters.
///
</file context>
| /// Each [`CreateEmailBaseOptions`] in the batch supports `tags`, in addition to | |
| /// the other send-email body parameters. | |
| /// Batch sends support `tags` on each [`CreateEmailBaseOptions`]. The | |
| /// `attachments` and `scheduled_at` fields are not supported. |
Dismissed because Cubic found issues in a newer review.
Avoid implying all send-email fields, such as attachments, apply to batch. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Summary
The batch send API supports
tagson each email in the batch. This crate already exposes tags onCreateEmailBaseOptions, which batch send uses — this change documents that and adds coverage.Changes
tagsonBatchSvc::sendSummary by cubic
Documented and tested batch send support for per-email
tags. Updated docs to state that batch supportstagsonly and notattachmentsorscheduled_at, removing aCreateEmailBaseOptionslink that implied otherwise.Written for commit bfdb267. Summary will update on new commits.