Update Webpack example with latest css-loader config#491
Open
pascalduez wants to merge 1 commit intoreshaped-ui:mainfrom
Open
Update Webpack example with latest css-loader config#491pascalduez wants to merge 1 commit intoreshaped-ui:mainfrom
pascalduez wants to merge 1 commit intoreshaped-ui:mainfrom
Conversation
pascalduez
commented
Nov 16, 2025
| */ | ||
|
|
||
| const path = require("path"); | ||
| const path = require("node:path"); |
Contributor
Author
There was a problem hiding this comment.
Best practice to prevent unintentionally loading a path module from node_modules.
pascalduez
commented
Nov 16, 2025
| output: { | ||
| path: path.resolve(__dirname, "dist"), | ||
| filename: "[name]-[hash].js", | ||
| filename: "[name]-[contenthash].js", |
Contributor
Author
There was a problem hiding this comment.
[hash] is deprecated and prints a DEP_WEBPACK_TEMPLATE_PATH_PLUGIN_REPLACE_PATH_VARIABLES_HASH warning in console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user follow the Webpack installation guide at https://reshaped.so/docs/getting-started/integrations/webpack, it will get
css-loaderlatest version:7.1.2at time of writing.Which means the documented config will not work with Reshaped.
Since version
7.xcss-loaderchanged quite a bit their CSS modules default handling.See https://github.com/webpack/css-loader/releases/tag/v7.0.0
So to be able to be compatible with Reshaped sources
import s from "./Component.module.css", this config is now required.This should be updated on the Reshaped website as well, but I don't think its sources are available?