Skip to content

fix: auth module dns resolution and code quality#9

Open
Vaishnav88sk wants to merge 1 commit into
reshaprio:mainfrom
Vaishnav88sk:fix/auth-code-quality-and-dns
Open

fix: auth module dns resolution and code quality#9
Vaishnav88sk wants to merge 1 commit into
reshaprio:mainfrom
Vaishnav88sk:fix/auth-code-quality-and-dns

Conversation

@Vaishnav88sk

Copy link
Copy Markdown

This PR addresses two critical issues found in the operator/auth module:

  1. DNS Resolution Double-Suffix Bug:
    If a user provided a Fully Qualified Domain Name (FQDN) via the reshapr.io/instance annotation that already contained .svc.cluster.local, ReshaprApiClientFactory would append the suffix a second time, resulting in an UnknownHostException. This is now fixed by checking if the suffix already exists.

  2. Code Quality / Concurrency Bug:
    In ReshaprAuthenticationService, the exception handler was unconditionally calling Thread.currentThread().interrupt() on IOException. This is a concurrency anti-pattern that can disrupt thread-pool behavior on simple network timeouts. The IOException and InterruptedException catch blocks have been split to properly isolate the thread interruption logic.

Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
@Vaishnav88sk Vaishnav88sk requested a review from lbroudoux as a code owner June 9, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant