fix: auth module dns resolution and code quality#9
Open
Vaishnav88sk wants to merge 1 commit into
Open
Conversation
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two critical issues found in the
operator/authmodule:DNS Resolution Double-Suffix Bug:
If a user provided a Fully Qualified Domain Name (FQDN) via the
reshapr.io/instanceannotation that already contained.svc.cluster.local,ReshaprApiClientFactorywould append the suffix a second time, resulting in anUnknownHostException. This is now fixed by checking if the suffix already exists.Code Quality / Concurrency Bug:
In
ReshaprAuthenticationService, the exception handler was unconditionally callingThread.currentThread().interrupt()onIOException. This is a concurrency anti-pattern that can disrupt thread-pool behavior on simple network timeouts. TheIOExceptionandInterruptedExceptioncatch blocks have been split to properly isolate the thread interruption logic.