feat: Kubernetes admission controller story for Reshapr proxy as a sidecar container #123#147
Closed
Vaishnav88sk wants to merge 2 commits into
Closed
feat: Kubernetes admission controller story for Reshapr proxy as a sidecar container #123#147Vaishnav88sk wants to merge 2 commits into
Vaishnav88sk wants to merge 2 commits into
Conversation
…shaprio#123) Implements a Mutating Admission Webhook in the control-plane to automatically inject the reshapr-proxy container into Pods annotated with io.reshapr/inject: 'true'. Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Contributor
Author
|
Sorry for some non formatted code. |
Vaishnav88sk
force-pushed
the
issue-123-mutating-webhook
branch
3 times, most recently
from
15405fe to
28f60e8
Compare
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Vaishnav88sk
force-pushed
the
issue-123-mutating-webhook
branch
from
28f60e8 to
f3a6fbc
Compare
Member
|
Great start but please check here: #123 (comment) |
lbroudoux
added
question
Contributor
Author
|
Closing this PR. Issue migrated to reshapr-controllers repo. Refer reshaprio/reshapr-controllers#4 and PR reshaprio/reshapr-controllers#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #123
It uses the
quarkus-kubernetes-clientandzjsonpatchto expose an/api/v1/webhooks/mutateendpoint that parses incoming AdmissionReview requests. If a Pod is submitted with theio.reshapr/inject: "true"annotation, the webhook generates a JSON patch to inject the reshapr-proxycontainer.