fix: extract request-scoped values before virtual thread in emitAuditEvent#194
Open
Harishrs2006 wants to merge 1 commit into
Open
fix: extract request-scoped values before virtual thread in emitAuditEvent#194Harishrs2006 wants to merge 1 commit into
Harishrs2006 wants to merge 1 commit into
Conversation
…Event Fixes reshaprio#186 Variables captured inside Thread.startVirtualThread were read from the Vert.x HttpServerRequest after the HTTP response completed. Vert.x recycles the connection context at that point, so remoteAddress() and getHeader() on the virtual thread could throw IllegalStateException or return stale data, silently dropping audit logs. Fix: move all request.* and serverRequest.* accesses to before the Thread.startVirtualThread() call. durationMs and traceId were already correctly captured in this scope. Signed-off-by: Harish R S <harishrs21082006@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
Fix: move all request.* and serverRequest.* accesses to before the
Thread.startVirtualThread() call,
where the Vert.x context is still live