feat: Add support for user-defined comment directives#566
Open
Otard95 wants to merge 6 commits intorest-nvim:mainfrom
Open
feat: Add support for user-defined comment directives#566Otard95 wants to merge 6 commits intorest-nvim:mainfrom
Otard95 wants to merge 6 commits intorest-nvim:mainfrom
Conversation
Author
|
I suppose one consideration should be: Should we reimplement the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
custom_directivesconfig option that lets users register handlers for# @directivecomments.This would be a table of keyed functions where the key is the directive and the function gets called with the space separated arguments that follow.
For example, given:
# @var foo barwould be equivalent to@foo = bar.Personally I'd find this very useful for securely getting values out of my password store (example below). But I see this being quite useful in general. And as you can see the implementation is really quite simple.
Of course, you could technically achieve something similar with a post-request script. This feature is more so to handle the case where you want to do mostly the same action many times or in many places, at that point copy-pasting the script around becomes very verbose and not to mention hard to maintain.
Password store example:
Then: