fix: improve concurrent behavior of removeNode and removeConnection#732
Merged
Ni55aN merged 1 commit intoJun 30, 2025
Merged
Conversation
forasugais
force-pushed
the
fix/remove_node_connection
branch
from
June 23, 2025 01:39
982c4b1 to
4229f1f
Compare
forasugais
changed the title
Ni55aN
merged commit Jun 30, 2025
9487786
into
retejs:fix/race-condition-removing
3 of 4 checks passed
Contributor
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
@forasugais thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit improves the concurrent behavior of removeNode and removeConnection.
In the previous code, removing multiple nodes or connections required awaiting each remove call inside a loop.
This may not be recommended depending on the linter configuration.
ref. https://eslint.org/docs/latest/rules/no-await-in-loop
Related Issues
#720
Checklist
Additional Notes
Sorry, I wasn't able to run rete-qa tests due to installation errors. (Maybe my PC doesn't have enough memory...)