fix: drop transient items when player loses connection#183
Open
OldManYells wants to merge 1 commit intoretromcorg:masterfrom
Open
fix: drop transient items when player loses connection#183OldManYells wants to merge 1 commit intoretromcorg:masterfrom
OldManYells wants to merge 1 commit intoretromcorg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request
Description
There's a vanilla bug where on client crash whether single player or multiplayer, items in transient inventories (cursor, crafting inventory or workbench) get "lost" as they're are not accounted for and not even dropped on the ground.
This PR seems to fix that issue for Poseidon server.
Edit: As i typically do, also added some function wrapping for renaming but since this was mainly a quick attempt to fix the issue i didn't go through the whole flow doing that because it would require more time to ensure that proper naming was set. This in particular seems fairly easy