Floating Point Frontend: rework compare x86 helpers#7
Open
andrealinux1 wants to merge 1 commit into
Open
Conversation
andrealinux1
force-pushed
the
feature/floating-point-frontend
branch
3 times, most recently
from
30feee3 to
8d8015a
Compare
Insert a layer of indirection with the `lookup_comis_eflags` function, so that the GEP, generated in LLVMIR, by the lookup into the `comis_eflags` array, is kept hidden inside this helper and does not reach the helper bodies.
andrealinux1
force-pushed
the
feature/floating-point-frontend
branch
from
8d8015a to
29640c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We insert a layer of indirection with the
lookup_comis_eflagsfunction, so that the GEP, generated in LLVMIR, by the lookup into thecomis_eflagsarray, is kept hidden inside this helper and does not reach the helper bodies.