Skip to content

refactor: get rid of umbrella#51

Merged
revolko merged 6 commits intomasterfrom
refactor/integrate-boundary
Sep 29, 2025
Merged

refactor: get rid of umbrella#51
revolko merged 6 commits intomasterfrom
refactor/integrate-boundary

Conversation

@revolko
Copy link
Copy Markdown
Owner

@revolko revolko commented Sep 20, 2025

Umbrella is suitable for projects that compile only certain applications when releasing. Even though it may seem that dbreplex is such project, it is not. Every release will contian all publishers/subscribers.

Another reasons for switching from the umbrella structure are nicely summarized here:
https://elixirforum.com/t/migrating-off-of-an-umbrella-app-structure/53735/6

@revolko revolko force-pushed the refactor/integrate-boundary branch 4 times, most recently from b6f17a0 to 1e9b73d Compare September 20, 2025 20:07
@revolko
Copy link
Copy Markdown
Owner Author

revolko commented Sep 24, 2025

TODO:

  • remove .formatter changes from all commits
  • fix CI (I had the same problem locally and the issue was solved by removing build directory, so maybe some caching issue?) ---> restart helped, so really just caching issue

Umbrella is suitable for projects that compile only certain applications
when releasing. Even though it may seem that dbreplex is such project,
it is not. Every release will contian all publishers/subscribers.

Another reasons for switching from the umbrella structure are nicely
summarized here:
https://elixirforum.com/t/migrating-off-of-an-umbrella-app-structure/53735/6
And move pgsubscriber in the new folder.
And move FilePublisher to the new folder.
@revolko revolko force-pushed the refactor/integrate-boundary branch from acde03c to ecc6fe8 Compare September 29, 2025 19:07
@revolko revolko marked this pull request as ready for review September 29, 2025 19:10
@revolko revolko merged commit aa9db8f into master Sep 29, 2025
4 of 6 checks passed
@revolko revolko deleted the refactor/integrate-boundary branch September 29, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant