Fix string with escape characters using existing string with escaped characters#31
Open
jordoh wants to merge 2 commits intorgcl:masterfrom
Open
Fix string with escape characters using existing string with escaped characters#31jordoh wants to merge 2 commits intorgcl:masterfrom
jordoh wants to merge 2 commits intorgcl:masterfrom
Conversation
Fixes a string containing a single space (" ") being used as the string for a string containing a single plus sign ("+").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After packing a string containing an escaped character, a subsequent string containing the escape character would erroneously use the string with the escaped character. I've included a test that demonstrates this behavior.
This PR updates the string re-use check to escape the string before checking for a matching string in the dictionary.