-
Notifications
You must be signed in to change notification settings - Fork 0
Dlp/speedtest revised #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dominicpham03
wants to merge
24
commits into
master
Choose a base branch
from
dlp/speedtest_revised
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test and speed test results
* Add deeplink functionality for FDK app login (#9) * Add deeplink functionality for FDK app login Implement deeplink handling to allow users to click a link (fdk://login?...) to login to the FDK app, similar to the ATT-FE-Tool functionality. Changes: - Add app_links dependency for handling deeplinks - Create DeeplinkService with validation, deduplication, and Base64 support - Create DeeplinkProvider for Riverpod integration - Configure Android intent filters for fdk:// scheme - Configure iOS URL scheme for fdk:// - Add GoRouter redirect to handle deeplink URLs gracefully - Initialize deeplink service in main.dart with confirmation dialog - Add comprehensive unit tests for deeplink functionality The deeplink flow: 1. User clicks fdk://login?fqdn=...&apiKey=...&login=... link 2. App opens and shows CredentialApprovalSheet for confirmation 3. On approval, authenticates via existing auth flow 4. Navigates to home screen on success Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Removing local files --------- Co-authored-by: Zachary Wilhite <z12aggie@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Fixing author * Integrate room readiness status labels into Locations UI Update Locations view to display proper status labels (Ready/Partial/Down/Empty) instead of generic "Has Issues" text. Integrates RoomStatus from room_readiness feature into RoomViewModel and propagates status-based colors through the UI. Changes: - Add RoomStatus to RoomViewModel with statusText getter - Update RoomStats with partial/down/empty counts - Replace "Has Issues" with status labels in rooms_screen and room_detail_screen - Add status-specific colors (green/orange/red/grey) - Add default staging username fallback in environment.dart - Fix mock stubs in optimization_verification_test.dart - Add unit tests for room view models and staging auth Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Zachary Wilhite <z12aggie@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Add deeplink functionality for FDK app login (#9) * Add deeplink functionality for FDK app login Implement deeplink handling to allow users to click a link (fdk://login?...) to login to the FDK app, similar to the ATT-FE-Tool functionality. Changes: - Add app_links dependency for handling deeplinks - Create DeeplinkService with validation, deduplication, and Base64 support - Create DeeplinkProvider for Riverpod integration - Configure Android intent filters for fdk:// scheme - Configure iOS URL scheme for fdk:// - Add GoRouter redirect to handle deeplink URLs gracefully - Initialize deeplink service in main.dart with confirmation dialog - Add comprehensive unit tests for deeplink functionality The deeplink flow: 1. User clicks fdk://login?fqdn=...&apiKey=...&login=... link 2. App opens and shows CredentialApprovalSheet for confirmation 3. On approval, authenticates via existing auth flow 4. Navigates to home screen on success Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Removing local files --------- Co-authored-by: Zachary Wilhite <z12aggie@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Fixing author * Integrate room readiness status labels into Locations UI Update Locations view to display proper status labels (Ready/Partial/Down/Empty) instead of generic "Has Issues" text. Integrates RoomStatus from room_readiness feature into RoomViewModel and propagates status-based colors through the UI. Changes: - Add RoomStatus to RoomViewModel with statusText getter - Update RoomStats with partial/down/empty counts - Replace "Has Issues" with status labels in rooms_screen and room_detail_screen - Add status-specific colors (green/orange/red/grey) - Add default staging username fallback in environment.dart - Fix mock stubs in optimization_verification_test.dart - Add unit tests for room view models and staging auth Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add deployment phase filtering with persistence Implement phase filtering for devices with session persistence: - Add PhaseFilterState and PhaseFilterNotifier for state management - Filter devices by phase using metadata['phase'] field - Persist selected phase filter to SharedPreferences - Add PopupMenuButton dropdown UI in devices screen - Support "All Phases" and "Unassigned" special filters - Use ref.listen() to sync phase changes without resetting UI state Changes: - lib/features/devices/presentation/providers/phase_filter_provider.dart (new) - lib/features/devices/presentation/providers/device_ui_state_provider.dart - lib/features/devices/presentation/screens/devices_screen.dart - lib/core/services/storage_service.dart - test/features/devices/presentation/providers/phase_filter_test.dart (new) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix issue with metadata --------- Co-authored-by: Zachary Wilhite <z12aggie@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…test and speed test results
309db13 to
88d756f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised version of speed test