Fix payload not init on error case; Fix payload not overwriting primitives (#50)#53
Open
betafcc wants to merge 1 commit intorgstephens:masterfrom
Open
Fix payload not init on error case; Fix payload not overwriting primitives (#50)#53betafcc wants to merge 1 commit intorgstephens:masterfrom
betafcc wants to merge 1 commit intorgstephens:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the last fix (#45), the payload is not correctly being set, see the line:
node-red-contrib-graphql/graphql.js
Line 154 in 36374fa
If the payload is previously set to a string (as noted by #50), it will not work properly
Besides that, the payload was init only for success case, but not for error case, this PR fixes the payload initialization on both cases.