Skip to content

label: added \n parsing & rotation#608

Merged
rgthree merged 2 commits intorgthree:mainfrom
sfinktah:sfink-label-multiline-rotate
Nov 5, 2025
Merged

label: added \n parsing & rotation#608
rgthree merged 2 commits intorgthree:mainfrom
sfinktah:sfink-label-multiline-rotate

Conversation

@sfinktah
Copy link
Copy Markdown
Contributor

@sfinktah sfinktah commented Nov 1, 2025

Addresses issue #546 by adding multi-line via \n, and additionally adds angle for rotation as suggested in the same issue.

image

note: could not get npm run build / tsc / build.py to build without a bunch of errors and then manually inserting a leading / in-front of scripts/app.js, but I'm sure that's not news to you.

@rgthree
Copy link
Copy Markdown
Owner

rgthree commented Nov 1, 2025

This LGTM. Though we do want to do the build step.

note: could not get npm run build / tsc / build.py to build without a bunch of errors and then manually inserting a leading / in-front of scripts/app.js, but I'm sure that's not news to you.

I assume this means manually running the ./__build__.py file (without npm)? What errors were you getting? Are you on Linux or Windows?

@sfinktah
Copy link
Copy Markdown
Contributor Author

sfinktah commented Nov 4, 2025

Well, not being a total noob, I ran npm run build first. But after checking it's definition in package.json I tried drilling down to the specific commands to see if it would make any difference.

[edit 2] You might want to skip to the end of this comment, after to think this all through, I have a premonition you might have solved this like I might have. Yup. I was right. Let me poke around this build script and see why it's not kicking in. Probably Windows related.

The entire log is here: https://pbbin.com/melipizume.typescript though it will just tell you that nothing is exported from comfyui, which you already know.

much deleted stuff

So, if this was me, I would take the laziest approach possible and just doing a s/^\(\s*\)declare /\1export & in vim to the whole index.d.ts file.

[edit 1] Which it turns out, does fix the problem. So, time to delve into __build__.py and see how you did it, and why Windows doesn't like your solution. FWIW I do have sed/perl/vim/vi/ex/awk in my path, so that (probably) isn't it.

[edit 2] I am guessing you did as I did, and just did a search & replace in vim on comfyui/frontend's index.d.ts. I automated that step, fixed a small issue with paths under windows, and generally made a mess by adding a heap of failure checks. Either way, the mystery is solved #609

@sfinktah
Copy link
Copy Markdown
Contributor Author

sfinktah commented Nov 4, 2025

... and commited the resultant build of label.js. No other changes resulted due to the new build process, so it definately works here in Windows land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants