fix: add retry with exp backoff to action plugins#167
Open
Conversation
The anarchy_subject_update and anarchy_schedule_action plugins
call response.json() without error handling. When the anarchy
API returns an empty body or a non-JSON response due to
transient issues, json.loads("") raises JSONDecodeError:
"Expecting value: line 1 column 1 (char 0)". This causes
intermittent provision failures that succeed on retry.
- Add retry loop (3 attempts, exponential backoff: 5s, 10s)
- Add response.raise_for_status() before parsing JSON
- Catch RequestException, ValueError, and KeyError
- Log warnings on each failed attempt via ansible display
- Return actionable error message when all retries exhausted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anarchy_subject_update and anarchy_schedule_action plugins call response.json() without error handling. When the anarchy API returns an empty body or a non-JSON response due to transient issues,
json.loads("")raises JSONDecodeError: "Expecting value: line 1 column 1 (char 0)". This causes intermittent provision failures that succeed on retry.