WP_REDIS_SERVERLESS_WORKAROUND#596
Open
ustramooner wants to merge 36 commits intorhubarbgroup:developfrom
Open
WP_REDIS_SERVERLESS_WORKAROUND#596ustramooner wants to merge 36 commits intorhubarbgroup:developfrom
ustramooner wants to merge 36 commits intorhubarbgroup:developfrom
Conversation
# Conflicts: # phpstan-baseline.neon
* Fixed loading textdomain in * use helper --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
…ubarbgroup#522) * Add check that redis_version is set * Fetch Redis server info for replicated connections * change style * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
* Fix Predis cluster flush * Update CHANGELOG.md --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
…#535) * Add filter and constant to allow customizing who can manage the plugin * Update CHANGELOG.md * Update README.md --------- Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # includes/object-cache.php # languages/redis-cache.pot # readme.txt # redis-cache.php
Member
|
Can you explain what tenant prefixes are, the issue with them and how this workaround will fix the issue? |
…DIS_SERVERLESS_WORKAROUND
tillkruss
requested changes
Mar 3, 2026
| <?php if ( isset( $diagnostics['persistent'] ) ) : ?> | ||
| <tr> | ||
| <th><?php esc_html_e( 'Persistent Connection:', 'redis-cache' ); ?></th> | ||
| <td><code><?php echo esc_html( $diagnostics['persistent'] ? 'Yes' : 'No' ); ?></code></td> |
Member
There was a problem hiding this comment.
Make sure these are translatable.
|
|
||
| $san_key = $this->sanitize_key_part( $key ); | ||
| $derived_key = $derived_keys[ $key ] = $this->fast_build_key( $san_key, $san_group ); | ||
| if (defined('WP_REDIS_SERVERLESS_WORKAROUND') && WP_REDIS_SERVERLESS_WORKAROUND ) { |
Member
There was a problem hiding this comment.
This needs a README entry with explanation
| $info['Timeout'] = $wp_object_cache->diagnostics['timeout'] ?? false; | ||
| $info['Read Timeout'] = $wp_object_cache->diagnostics['read_timeout'] ?? false; | ||
| $info['Retry Interval'] = $wp_object_cache->diagnostics['retry_interval'] ?? false; | ||
| $info['Persistent'] = $wp_object_cache->diagnostics['persistent'] ?? false; |
Member
There was a problem hiding this comment.
This PR needs several changelog entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS rds valkey serverless with tenant prefixes - i can't get the scan/keys function to work so have to use this very very clunky workaround. Any suggestions to get it working better i'm open for