fix(security): prevent shell injection in CLI tools#3
Open
Conversation
…jection - bin/push.js: Replace all execSync/shell string calls with execFileSync and array-based arguments across Layer 1, 2, and 3 push flows, removing shell interpretation of user-controlled data (commit messages, file paths) - bin/lib/installer.js: Replace execSync git clone with execFileSync, use http.extraheader instead of embedding token in clone URL (prevents token leakage in process listings and logs), add token format validation Findings addressed: M-02, M-04, L-04, L-09, L-10 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSyncwithexecFileSync+ array-based arguments inbin/push.jsandbin/lib/installer.jshttp.extraheaderfor git clone authentication instead of embedding token in URLFindings Addressed
bin/push.jsexecSync→execFileSyncwith array argsbin/lib/installer.jsexecSync→execFileSyncwith array argsbin/lib/installer.jsbin/lib/installer.jsbin/lib/installer.jshttp.extraheaderfor authTest plan
mega-brain push --layer 1still works (git add, commit, push flow)mega-brain push --layer 2with manifest paths (force-add, commit, push --force)mega-brain push --layer 3backup flow (add -A, force-add, reset secrets, commit, push --force)mega-brain push --dry-runshows correct outputfetchPremiumContent) with valid GitHub token🤖 Generated with Claude Code