Fix - now mutpos are generated from rdata even if you happen to have …#4
Open
mmagnus wants to merge 1 commit intoribokit:masterfrom
Open
Fix - now mutpos are generated from rdata even if you happen to have …#4mmagnus wants to merge 1 commit intoribokit:masterfrom
mmagnus wants to merge 1 commit intoribokit:masterfrom
Conversation
…`mutation:X1X` etc. & it seems to be faster anyway
Before:
>> output_Zscore_from_rdat('out.txt', 'RNAPZ14_1M7_0000.rdat')
Parsing file from rdat: RNAPZ14_1M7_0000.rdat
Number of reactivity lines: 59
mutpos (1 x 59) is generated from d_rdat.data_annotations.
Subscript indices must either be real positive integers or logicals.
Error in output_Zscore_from_rdat>get_Zscore_and_apply_filter (line 219)
Zscore_full( pos1, pos2(gp) ) = Zscore(:,gp) * ZSCORE_SCALING;
Error in output_Zscore_from_rdat (line 67)
[ Z, mutpos ] = get_Zscore_and_apply_filter( d, d_nomod, MEAN_EXPOSURE_CUTOFF,
ZSCORE_OFFSET, APPLY_ZSCORE_OFFSET, ONLY_A_C, ignore_mut );
now you will get the plot!
Signed-off-by: Marcin Magnus <magnus@genesilico.pl> & Filip Ciepiela
Author
|
I hope it does not break anything else. |
Contributor
|
@mmagnus I just saw this. We are working on the next release of hitrace and I wanted to include your fix. I can merge in your pull request -- could you actually merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
mutation:X1Xetc. & it seems to be faster anywayBefore:
now you will get the plot!
Signed-off-by: Marcin Magnus magnus@genesilico.pl & Filip Ciepiela