Skip to content

Comments

Fix - now mutpos are generated from rdata even if you happen to have …#4

Open
mmagnus wants to merge 1 commit intoribokit:masterfrom
mmagnus:master
Open

Fix - now mutpos are generated from rdata even if you happen to have …#4
mmagnus wants to merge 1 commit intoribokit:masterfrom
mmagnus:master

Conversation

@mmagnus
Copy link

@mmagnus mmagnus commented Oct 20, 2015

mutation:X1X etc. & it seems to be faster anyway

Before:

>> output_Zscore_from_rdat('out.txt', 'RNAPZ14_1M7_0000.rdat')
Parsing file from rdat: RNAPZ14_1M7_0000.rdat
Number of reactivity lines: 59
mutpos (1 x 59) is generated from d_rdat.data_annotations.
Subscript indices must either be real positive integers or logicals.

Error in output_Zscore_from_rdat>get_Zscore_and_apply_filter (line 219)
Zscore_full( pos1, pos2(gp) ) = Zscore(:,gp) * ZSCORE_SCALING;

Error in output_Zscore_from_rdat (line 67)
  [ Z, mutpos ] = get_Zscore_and_apply_filter( d, d_nomod, MEAN_EXPOSURE_CUTOFF,
  ZSCORE_OFFSET, APPLY_ZSCORE_OFFSET, ONLY_A_C, ignore_mut );

now you will get the plot!

Signed-off-by: Marcin Magnus magnus@genesilico.pl & Filip Ciepiela

…`mutation:X1X` etc. & it seems to be faster anyway

Before:

	>> output_Zscore_from_rdat('out.txt', 'RNAPZ14_1M7_0000.rdat')
	Parsing file from rdat: RNAPZ14_1M7_0000.rdat
	Number of reactivity lines: 59
	mutpos (1 x 59) is generated from d_rdat.data_annotations.
	Subscript indices must either be real positive integers or logicals.

	Error in output_Zscore_from_rdat>get_Zscore_and_apply_filter (line 219)
	Zscore_full( pos1, pos2(gp) ) = Zscore(:,gp) * ZSCORE_SCALING;

	Error in output_Zscore_from_rdat (line 67)
	  [ Z, mutpos ] = get_Zscore_and_apply_filter( d, d_nomod, MEAN_EXPOSURE_CUTOFF,
	  ZSCORE_OFFSET, APPLY_ZSCORE_OFFSET, ONLY_A_C, ignore_mut );

now you will get the plot!

Signed-off-by: Marcin Magnus <magnus@genesilico.pl> & Filip Ciepiela
@mmagnus
Copy link
Author

mmagnus commented Oct 20, 2015

I hope it does not break anything else.

@rhiju
Copy link
Contributor

rhiju commented May 28, 2017

@mmagnus I just saw this. We are working on the next release of hitrace and I wanted to include your fix.

I can merge in your pull request -- could you actually merge master into your branch first to resolve the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants