fix: Derive backoffice bundle cache-bust ?v= from version.json#308
Merged
Conversation
The entry point's `?v=` query in umbraco-package.json was frozen at a stale value (6.0.0-rc1) because the vite cacheBustImports plugin read the version from public/umbraco-package.json and only appended ?v= when absent, while the UpdatePackageManifestVersion MSBuild target fixed `version` but never the `?v=`. The entry bundle URL never changed across releases, so browsers kept serving a cached old frontend after upgrading. Read the cache-bust token from version.json (bumped every release) and always (re)write ?v= to it; keep the manifest version field in sync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v6 counterpart of the v5 fix (#307).
The entry point's cache-bust query was frozen at
?v=6.0.0-rc1across releases because the vite plugin read the version frompublic/umbraco-package.jsonand the MSBuild target only fixedversion, never?v=. Browsers kept serving cached old JS after upgrading.Now the
?v=(and the manifestversion) are sourced fromversion.json(bumped every release).npm run buildon this branch (version.json = 6.1.0-alpha) produces:🤖 Generated with Claude Code