fix(server): narrow terminal size types after validation#1
Open
RonanKMcGovern wants to merge 2 commits intoricklamers:mainfrom
Open
fix(server): narrow terminal size types after validation#1RonanKMcGovern wants to merge 2 commits intoricklamers:mainfrom
RonanKMcGovern wants to merge 2 commits intoricklamers:mainfrom
Conversation
The `cols` and `rows` fields from request bodies are typed as `number | undefined`, but the daemon spawn message requires `number`. `isValidTerminalSize()` already validates them at runtime; add explicit casts so TypeScript accepts the assignment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the issues encountered during a fresh setup: - node:sqlite requires --experimental-sqlite on Node 22-23 - daemon auth token configuration (env var and config file) - CLAUDECODE env vars must be stripped when launching from Claude Code - daemon --workspace flag needed to discover repos - Makefile is Linux-only (ss/fuser) - added troubleshooting table for common errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/serverwherecolsandrows(typednumber | undefinedfrom request bodies) were passed to the daemon spawn message which requiresnumberisValidTerminalSize()guard already validates them at runtime; added explicitas numbercasts so TypeScript accepts the assignmentprocesses.ts(1 location) andworktrees.ts(3 locations)Test plan
pnpm buildpasses with no errors🤖 Generated with Claude Code