-
Notifications
You must be signed in to change notification settings - Fork 16
Openfold addition #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ult values to a dir if they don't exist
abcfold/output/openfold3.py
Outdated
| logger = logging.getLogger("logger") | ||
|
|
||
|
|
||
| def fix_mmcif(infile, outfile): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to preemptively comment to say I don't think this is the best solution, but it does work. If you can think of a different way to fix it though, let me know!
abcfold/output/openfold3.py
Outdated
|
|
||
| with open(infile) as fin, open(outfile, "w") as fout: | ||
|
|
||
| fout.write("data_structure\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try writing as one big block i.e. """"
text
"""
abcfold/output/openfold3.py
Outdated
| fout.write("_atom_site.id\n") | ||
| fout.write("_atom_site.occupancy\n") | ||
|
|
||
| for line in fin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a comment explaining what this does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a class method fro cif file handler called from_openfold which handles this logic
|
The check to see if singularity is found on the system sometimes returns true even if singularity is not none. |
Changes to include OpenFold3 into ABCFold
The main changes include:
I've added tests and updated the documentation.