fix(shell): allow default local API URL bootstrap#2
Open
skulidropek wants to merge 5 commits into
Conversation
* fix(shell): prepare host-backed controller builds - Default controller runtime to host Docker with socket mount - Initialize the pinned Skiller submodule before controller revision/build - Include Skiller inputs in controller revision hashing * test(shell): cover controller compose preparation * fix(shell): support containerized remote Docker controller startup * fix(shell): preserve remote and isolated controller bootstrap * fix(shell): make isolated controller fallback self-contained * fix(shell): address controller runtime review comments --------- Co-authored-by: skulidropek <66840575+skulidropek@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Conflicts: # packages/app/src/docker-git/controller.ts # packages/app/tests/docker-git/controller-ready.test.ts # packages/app/tests/docker-git/controller.test.ts
skulidropek
force-pushed
the
codex/default-local-api-url-bootstrap-pr351
branch
from
5386e55 to
db0594b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This is a one-commit follow-up for ProverCoderAI#351. It fixes the case where a persisted Windows env var like DOCKER_GIT_API_URL=http://127.0.0.1:3334 prevents local Docker bootstrap.
Verification