Skip to content

enhancement: button presses feel more realistic #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericlewis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhancement: button presses feel more realistic #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions DeltaCore/UI/Controller/ButtonsInputView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ class ButtonsInputView: UIView

private let imageView = UIImageView(frame: .zero)

private let feedbackGenerator = UIImpactFeedbackGenerator(style: .medium)

private var downFeedbackGenerator: UIImpactFeedbackGenerator?
private var upFeedbackGenerator: UIImpactFeedbackGenerator?

private var touchInputsMappingDictionary: [UITouch: Set<AnyInput>] = [:]
private var previousTouchInputs = Set<AnyInput>()
private var touchInputs: Set<AnyInput> {
Expand All @@ -47,8 +48,17 @@ class ButtonsInputView: UIView

self.isMultipleTouchEnabled = true

self.feedbackGenerator.prepare()
if #available(iOS 13.0, *) {
self.downFeedbackGenerator = UIImpactFeedbackGenerator(style: .rigid)
self.upFeedbackGenerator = UIImpactFeedbackGenerator(style: .soft)
} else {
self.downFeedbackGenerator = UIImpactFeedbackGenerator(style: .medium)
self.upFeedbackGenerator = UIImpactFeedbackGenerator(style: .light)
}

self.downFeedbackGenerator?.prepare()
self.upFeedbackGenerator?.prepare()

self.imageView.translatesAutoresizingMaskIntoConstraints = false
self.addSubview(self.imageView)

Expand Down Expand Up @@ -140,7 +150,7 @@ private extension ButtonsInputView
{
switch UIDevice.current.feedbackSupportLevel
{
case .feedbackGenerator: self.feedbackGenerator.impactOccurred()
case .feedbackGenerator: self.downFeedbackGenerator?.impactOccurred()
case .basic, .unsupported: UIDevice.current.vibrate()
}
}
Expand All @@ -149,6 +159,15 @@ private extension ButtonsInputView
if !deactivatedInputs.isEmpty
{
self.deactivateInputsHandler?(deactivatedInputs)

if self.isHapticFeedbackEnabled
{
switch UIDevice.current.feedbackSupportLevel
{
case .feedbackGenerator: self.upFeedbackGenerator?.impactOccurred()
case .basic, .unsupported: break
}
}
}
}
}