feat: localization support#9570
Open
AdityaHegde wants to merge 10 commits into
Open
Conversation
AdityaHegde
force-pushed
the
feat/localization
branch
from
e400735 to
d7d35f9
Compare
AdityaHegde
changed the title
Collaborator
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1bc287c3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Paraglide JS internationalization (i18n) scaffolding across the SvelteKit frontends (web-local, web-admin) and shared i18n assets/config under web-common, plus a lightweight guard script to prevent reintroducing hardcoded strings in already-migrated areas.
Changes:
- Integrate
@inlang/paraglide-jsvia Vite plugins and SvelteKit hooks; set HTMLlangdynamically at render time. - Introduce
web-common/src/lib/i18n/project scaffolding (inlang project config + initialen.jsonmessage). - Add
build:i18n+ CI quality-step wiring and ani18n-guardheuristic scanner.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| web-local/vite.config.ts | Adds Paraglide Vite plugin to compile i18n output during dev/build. |
| web-local/src/hooks.ts | Adds reroute hook for Paraglide URL delocalization. |
| web-local/src/hooks.server.ts | Adds server handle using Paraglide middleware and injects %lang%. |
| web-local/src/app.html | Switches <html lang> to a %lang% placeholder. |
| web-common/src/lib/i18n/README.md | Adds i18n documentation and conventions for message usage/keys. |
| web-common/src/lib/i18n/messages/en.json | Adds initial base-locale message catalog. |
| web-common/src/lib/i18n/project.inlang/settings.json | Adds inlang project settings for message-format plugin + locales. |
| web-common/src/lib/i18n/project.inlang/README.md | Documents the unpacked inlang project folder contents. |
| web-common/src/lib/i18n/project.inlang/.meta.json | Tracks inlang SDK version metadata. |
| web-common/src/lib/i18n/project.inlang/.gitignore | Adds inlang-generated ignore rules for cache/settings.json. |
| web-admin/vite.config.ts | Adds Paraglide Vite plugin to compile i18n output during dev/build. |
| web-admin/src/routes/[organization]/+page.svelte | Replaces a hardcoded <title> string with a Paraglide message call. |
| web-admin/src/hooks.server.ts | Adds server handle using Paraglide middleware and injects %lang%. |
| web-admin/src/app.html | Switches <html lang> to a %lang% placeholder. |
| scripts/web-test-code-quality.sh | Runs i18n compile + i18n guard as part of quality checks. |
| scripts/i18n-guard.js | Adds a warning-only heuristic scan for hardcoded strings in migrated areas. |
| package.json | Adds build:i18n script and makes root build depend on it; adds @inlang/paraglide-js. |
| package-lock.json | Locks @inlang/paraglide-js and its dependency graph. |
| .prettierignore | Ignores generated Paraglide output and inlang cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| export const reroute: Reroute = (request) => { | ||
| return deLocalizeUrl(request.url).pathname; | ||
| }; |
Comment on lines
+8
to
+9
| See [`MIGRATION.md`](./MIGRATION.md) for the chunked plan to migrate existing | ||
| hardcoded strings. |
|
|
||
| ``` | ||
| lib/i18n/ | ||
| ├── messages/{en,de}.json # source translations (edit these) |
| ``` | ||
|
|
||
| - `messages/en.json` is the base locale and the source of truth for keys. | ||
| - `messages/de.json` is generated via machine translation; do not hand-maintain it. |
Comment on lines
+49
to
+50
| Locale detection uses the `["preferredLanguage", "baseLocale"]` strategy: the | ||
| browser's preferred language, falling back to English. |
Comment on lines
+1
to
+7
| # IF GIT SHOWED THAT THIS FILE CHANGED | ||
| # | ||
| # 1. RUN THE FOLLOWING COMMAND | ||
| # | ||
| # --- | ||
| # git rm --cached '**/*.inlang/.gitignore' | ||
| # --- |
Comment on lines
+27
to
+30
| ```sh | ||
| npm run build:i18n # compile messages/ -> gen/ | ||
| npm run machine-translate # fill in non-English locales from en.json | ||
| ``` |
Comment on lines
+9
to
+11
| "plugin.inlang.messageFormat": { | ||
| "pathPattern": "./messages/{locale}.json" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds just the boilerplate for paraglide i18n integration. Actual string replacements have been reverted and separate PRs will be raised for it.
Checklist: