Hide cloud edit entries without access#9617
Open
nishantmonu51 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens UI gating around cloud editing actions so that edit-related controls only appear (and related dialogs only mount) when cloud editing is enabled and the user has manageDev permissions for the project.
Changes:
- Hide the Project Card “Edit” dropdown item unless cloud editing is enabled for the project and the user can manage dev deployments.
- Prevent the edit-branch dialog from mounting when editing is not allowed.
- Restrict branch “Open editor” actions to the same cloud-editing +
manageDevpermission checks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web-admin/src/features/projects/ProjectCardActions.svelte | Adds a canEdit gate to conditionally render the Edit dropdown item. |
| web-admin/src/features/projects/ProjectCard.svelte | Computes per-project cloud-editing eligibility and avoids mounting the edit dialog when ineligible. |
| web-admin/src/features/branches/BranchesSection.svelte | Gates “Open editor” actions behind cloud-editing + manageDev and hardens transitory-status polling against undefined statuses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing