Implemented MovieRecommender class, All Junit tests passed #73
Open
AlfredoGJ wants to merge 6 commits intorilopez:masterfrom
Open
Implemented MovieRecommender class, All Junit tests passed #73AlfredoGJ wants to merge 6 commits intorilopez:masterfrom
AlfredoGJ wants to merge 6 commits intorilopez:masterfrom
Conversation
AlfredoGJ
changed the title
eseca
reviewed
Oct 11, 2019
…w user preference insertion
haydeeR
reviewed
Oct 12, 2019
|
|
||
| } | ||
|
|
||
| GenericPreference getPreference(String filePath) { |
There was a problem hiding this comment.
- Handle access modifier
- Investigated what kind of access do you have there.
| String userID = ""; | ||
| Float score = 0.0f; | ||
|
|
||
| BufferedReader reader; |
There was a problem hiding this comment.
This variable doesn't have any purpose here!
|
|
||
| void addPreference(String userID, String productID, float score) { | ||
|
|
||
| reviewCount++; |
There was a problem hiding this comment.
This part doesn't have any relationship with addPreference method.
Try to split the methods
Author
There was a problem hiding this comment.
Thanks, Hayde, I split the function
| return null; | ||
| } | ||
|
|
||
| void addPreference(String userID, String productID, float score) { |
…calration of the BufferReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution implemented reading from the movies.txt file and inserting reviews data into a FastByIDMap of PreferenceArray, this map is used to create the model.