Feature/candidate grid scroll#1854
Open
antigoneum wants to merge 2 commits into
Open
Conversation
Generated with Codex assistance.
Generated with Codex assistance.
Contributor
|
看上去像是要实现所谓的卷轴功能,但是目前这样的实现其实太多硬编逻辑,后面要清理是很难的。 预期更优的路径应该是librime要支持这种模式,设定卷轴行列,然后在开启了这种模式的时候不是用现有的单页的逻辑取数据,librime中selector或翻页等操作应该因应这种设定做对应的处理调整变化,等等。这样前端才不用硬编按键响应,行列信息等代码。 暂时更多只能是观望状态,望知悉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional candidate grid scroll layout
Summary
This PR adds an optional candidate grid layout for Weasel. When enabled through style
configuration, candidates can be shown as a fixed-column matrix and navigated by
row, similar to the native macOS candidate panel scroll behavior.
Generated with Codex assistance.
Behavior
style/layout/gridto opt into grid rendering.style/layout/grid_columns,grid_visible_rows,grid_cell_width, andgrid_cell_heightfor matrix sizing.+,=, and numpad+to move the active row downward.-and numpad-to move the active row upward.1..grid_columnsto select the candidate in the current row.5 visible rows.
Example configuration
Notes
The IPC style struct is extended with the grid fields, so all Weasel components
need to be rebuilt and installed from the same revision.
Test
.clang-format(
BasedOnStyle: Chromium,SortIncludes: false).WeaselUIandRimeWithWeaseltargets on Windows withVS Build Tools.
WeaselServercompilation passed dependency targets but final link wasblocked locally because
output/WeaselServer.exewas running.+,-, and number keys.