Fixes crash when no shared string index present.#1
Open
nramsbottom wants to merge 2 commits intorimland:masterfrom
Open
Fixes crash when no shared string index present.#1nramsbottom wants to merge 2 commits intorimland:masterfrom
nramsbottom wants to merge 2 commits intorimland:masterfrom
Conversation
…ence to anything in the shared strings list.
Author
Sample code I used to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received an Excel file that could not be opened because it caused a crash. After some debugging I determined that it is because the v element within a c element doesn't have a value and the existing code expects there to always be a value.
The file was generated by an external vendor, so I cannot alter how it is generated. The file can be opened by Excel and LibreOffice Calc with no issues.
I have produced a sample of the "broken" file here.
Book1.xlsx
This fix ensures that the shared string index is read as a string and parsed safely and the appropriate content placed into the cell.