Add retry with exponential backoff for transient external service calls#950
Open
aliyudotdev wants to merge 1 commit into
Open
Add retry with exponential backoff for transient external service calls#950aliyudotdev wants to merge 1 commit into
aliyudotdev wants to merge 1 commit into
Conversation
…lures
Wrap CdnService.invalidate, EmailService, and PaymentProviderService with
a shared RetryPolicy utility (3 retries, 1s base delay, 2x multiplier,
30s max, full jitter). Transient 5xx/network errors are retried; 4xx
client errors propagate immediately. Tracks retries via the
external_call_retry_total{service,attempt} Prometheus counter.
Closes rinafcode#886
|
@aliyudotdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetryPolicyutility (src/common/utils/retry-policy.ts): max 3 retries, 1s base delay, 2x multiplier, 30s max delay, full jitter. Client errors (4xx) are never retried; 5xx and network errors are.RetryPolicytoCdnService.invalidate, a newEmailService, and a newPaymentProviderService(wrapsIPaymentProvider).external_call_retry_total{service, attempt}incremented on every retry attempt.Test plan
npm test -- retry-policy cdn.service email.service payment-provider.serviceCloses #886