feat(security): re-sync biometric enabled state from SecureStore on foreground#725
Merged
Merged
Conversation
…oreground Stale Zustand state could show biometricEnabled: true after an OS update, reinstall, or external process cleared the SecureStore entry while the app was backgrounded. useBiometricAuth now re-reads isBiometricEnabled() on every active foreground transition and resets to false on divergence. isLoading blocks biometric UI until the initial sync completes.
|
@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biometricEnabledandsetBiometricEnabledtouseDeviceStoreas a runtime cache (no persistence — SecureStore remains the sole source of truth)useBiometricAuthnow callsisBiometricEnabled()fromsecureStorage.tson mount and on everybackground → activeforeground transition; if SecureStore no longer holds the entry, the cached value is reset tofalseregardless of what Zustand heldisLoading: trueis returned until the first sync completes so biometric UI cannot render against stale stateisEnabledrequires both!isDeviceCompromisedandbiometricEnabled— either gate being false blocks the promptisLoadinglifecycle, foreground re-sync, divergence reset (SecureStore cleared while Zustand cachedtrue), compromised-device override, no spurious sync on background-only transitionType of Change
Testing Done
Security Considerations
Performance Considerations
useCallback,useMemo) used appropriately to prevent unnecessary renders? —syncWithSecureStoreis wrapped inuseCallback;AppStatesubscription is cleaned up on unmountFlatListoptimized (e.g., usinggetItemLayout,keyExtractor)? — N/A to this changeuseEffectcleanup to avoid memory leaks)? —AppState.addEventListenersubscription is removed in theuseEffectcleanup;isSyncingis always cleared in afinallyblockAppStateis already part of React Native coreChecklist
Closes #590