fix(api): sanitize unhandled API error messages, add Sentry request context (#579)#745
Merged
RUKAYAT-CODER merged 2 commits intoJun 29, 2026
Conversation
…i-error-messages # Conflicts: # src/services/api/axios.config.ts
|
@eleven-smg Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #579
What
Unhandled API responses previously rejected with the raw
AxiosError, whose message/config can embed the full request URL. This adds a dedicated sanitization layer so the UI only ever sees a generic, URL-free message, while the full url + method are sent to Sentry request context for debugging.Changes
src/services/api/errorSanitization.ts— pure helpers:getSafeErrorMessage,containsUrlOrPath,sanitizeErrorMessage,buildSanitizedApiError(+SanitizedApiErrortype).src/services/api/__tests__/errorSanitization.test.ts— 30 tests covering every 4xx/5xx status, URL/path stripping, and payload shape.src/services/api/axios.config.ts— the default fallback now captures the request context to Sentry and rejects with a sanitized error.Notes on the issue text
apiService.ts, which doesn't exist in the current codebase; the relevant flow lives inaxios.config.ts, which is what I changed.sentryContextService.setContext('request', …), but that method doesn't exist on the service. I used the real API:captureException(error, { contexts: { request: {…} } }).error.userMessagefield — all.messagepaths are already sanitized and no consumer readsuserMessage. Happy to add it if you'd prefer strict adherence to the issue wording.Verification
npm test -- src/services/api/__tests__/errorSanitization.test.ts→ 30/30 passing.