fix: implement environment-aware error boundary security#846
Open
Nacho1499 wants to merge 1 commit into
Open
Conversation
Contributor
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
KingDavid9999
added a commit
to KingDavid9999/teachLink_web
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #708
PR Description:
This PR addresses the security vulnerability where was hardcoding . This caused full stack traces and internal implementation details to be exposed to end-users in production environments.ErrorBoundarySystemshowDetails={true}
Changes:
Updated to include an optional prop, defaulting to .ErrorBoundarySystem.tsxshowDetailsprocess.env.NODE_ENV === 'development'
Applied environment-based security guards to and .src/app/error.tsxsrc/app/global-error.tsx
Ensured includes mandatory and tags for Next.js consistency.global-error.tsx
Type of Change
[x] Bug fix
Checklist:
[x] Code follows project style guidelines
[x] Self-review completed
[x] No console errors
[x] Uses Lucide icons consistently
[x] Responsive design implemented
[x] Starknet best practices followed