fix: fail CI on test timeout and upload vitest report on failure (closes #706)#853
Open
boalambo wants to merge 4 commits into
Open
fix: fail CI on test timeout and upload vitest report on failure (closes #706)#853boalambo wants to merge 4 commits into
boalambo wants to merge 4 commits into
Conversation
|
@boalambo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
The 14 type errors flagged by the type-check job are pre-existing and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test step in
.github/workflows/ci.ymlwrappedvitest runin ashell timeout with
|| exit 0. This caused the CI job to always exitwith code 0 — even when tests failed or the suite timed out — giving
false confidence and allowing broken builds to be merged undetected.
Changes
|| exit 0fallback and the shelltimeoutwrappertimeout-minutes: 5directly on theRun Testsstep soGitHub Actions enforces the limit and fails the job on expiry
--reporter=json --outputFile=vitest-report.jsonto Vitestso a structured report is written during the run
Upload test report on failurestep that uploadsvitest-report.jsonas a CI artifact when the job failsAcceptance Criteria
Impacted Files
.github/workflows/ci.ymlCloses #706