Skip to content

Reject negative ROM lengths in uvm32_load #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ringtailsoftware merged 1 commit into from
Jul 16, 2026
Merged

Reject negative ROM lengths in uvm32_load #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/badcode/test/tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@ void test_giant_rom(void) {
TEST_ASSERT_EQUAL(false, uvm32_load(&vmst, rom_bin, UVM32_MEMORY_SIZE+1)); // if it reads off end of rom_bin, will crash
}

void test_negative_rom_length(void) {
uvm32_init(&vmst);
TEST_ASSERT_EQUAL(false, uvm32_load(&vmst, rom_bin, -1));
}

4 changes: 2 additions & 2 deletions uvm32/uvm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ void uvm32_init(uvm32_state_t *vmst) {
}

bool uvm32_load(uvm32_state_t *vmst, const uint8_t *rom, int len) {
if (len > UVM32_MEMORY_SIZE) {
// too big
if (len < 0 || len > UVM32_MEMORY_SIZE) {
// invalid length
return false;
}

Expand Down
Loading