Conversation
| button_save.setOnClickListener { | ||
| if (id == -1) { | ||
| val task = Task(edit_title.text.toString(), edit_desc.text.toString()) | ||
| launch(coroutineContext) { |
There was a problem hiding this comment.
мог и не указывать, он по дефотлу его взял бы
|
|
||
| class TaskPresenter : CoroutineScope { | ||
| private val taskRepository = TaskRepository() | ||
| override val coroutineContext: CoroutineContext |
There was a problem hiding this comment.
У тебя только один корутин скоуп. Можно его или в презентере делать или в активити. Но не 2 сразу
| private lateinit var taskAdapter: TaskAdapter | ||
| private val REQUEST_CODE = 1 | ||
| private val presenter = TaskPresenter() | ||
| override val coroutineContext: CoroutineContext |
There was a problem hiding this comment.
coroutineContext не чистится
NailShaykhrazievItis
approved these changes
Dec 29, 2020
| get() = SupervisorJob() + Dispatchers.IO | ||
|
|
||
| suspend fun getTaskList(): List<Task> = | ||
| withContext(coroutineContext) { taskRepository.getTasks() } |
There was a problem hiding this comment.
ты мог тут написать просто withContext(Dispatchers.IO), а скоуп был бы один, и активити из своего скоупа вызывал бы презентер, а так получается 2 скоупа, что не то
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.