Fix Story Map links for file-only locations#6
Open
hanley-development wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Story Map nodes for events whose
locationvalue is a file path without a:linesuffix.Previously, Story Map only linked location values that looked like
path/to/file.py:42. Events with locations likesrc/projectmem/commands/visualize.pycould render as disconnected floating event nodes even though the location pointed to a real file.Changes
src/projectmem/commands/visualize.py, to their file node.file:linelocations..\src\projectmem\cli.py.tests/.projectmem pre-commit hook.Verification
python -m pytest tests\test_visualize.py -qpython -m pytest -qNotes
This is a visualization-only fix. It does not change how events are recorded or stored; it only improves how existing
locationvalues are interpreted when building the Story Map graph.