feat: allow different send & receive ports#8
Open
umbertov wants to merge 1 commit intoripxorip:masterfrom
Open
feat: allow different send & receive ports#8umbertov wants to merge 1 commit intoripxorip:masterfrom
umbertov wants to merge 1 commit intoripxorip:masterfrom
Conversation
Owner
|
Hi @umbertov , thank you for your PRs, I would love to merge them. I have been working hard on a significant improvement in #4 , I will try to get this merged over the weekend then we can perhaps rebase the your PRs onto that? It adds support for a few of the features you have implemented, but most importantly for different audio backends such as ALSA directly. |
Author
f6cf66b to
3fd5e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the
--portCLI argument, and the GUI "Port" field, only indicate the port that the linux program will listen on, not the one where it will send the data, which was hardcoded to 8321. It is not possible to modify the listening port without rebuilding the executable.This PR does the following:
stream_porttolisten_port,--portto--listen-port--connect-portwhich is used insetup_recv_socket--connect-port