Skip to content

chore(mise.toml): use mise prepare#2860

Open
risu729 wants to merge 19 commits intomainfrom
mise-prep
Open

chore(mise.toml): use mise prepare#2860
risu729 wants to merge 19 commits intomainfrom
mise-prep

Conversation

@risu729
Copy link
Owner

@risu729 risu729 commented Dec 28, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 28, 2025 16:19
@risu729 risu729 enabled auto-merge (squash) December 28, 2025 16:19
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 28, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
dotfiles-worker bf1a3a2 Mar 22 2026, 12:06 AM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates from custom buni tasks to mise's built-in prepare feature for managing Bun dependency installation. The change consolidates dependency management into mise's native functionality, eliminating the need for custom task orchestration.

  • Replaces custom buni:root and buni:worker tasks with prepare.bun and prepare.bun_worker configurations
  • Removes all depends = ["buni:*"] dependencies from task definitions
  • Updates the GitHub workflow to use mise prepare --only bun instead of the custom task

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mise.toml Adds prepare.bun and prepare.bun_worker configurations with auto-run enabled; updates postinstall hook
tasks.toml Removes buni:root task definition and dependencies on it from commit, check:tsc:root, and check:jsonschema tasks
worker/tasks.toml Removes buni:worker task definition and dependencies on it from type checking and generation tasks
worker/tasks/worker/build Removes buni:worker dependency
cspell.config.cjs Removes "buni" from the custom words dictionary
.github/workflows/lint.yml Updates to use mise prepare --only bun instead of mise run buni:root

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"""

[prepare.bun]
auto = true
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prepare.bun configuration is missing sources and outputs fields that would enable proper dependency tracking and caching. Similar to prepare.bun_worker, this should include sources = ["bun.lock", "package.json"] and outputs = ["node_modules"] to ensure the prepare step only runs when dependencies change.

Suggested change
auto = true
auto = true
sources = ["bun.lock", "package.json"]
outputs = ["node_modules"]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants