Add lazy slice formatters to slogutil#1028
Merged
Merged
Conversation
Adds a couple slice helpers to `slogutil` that implement `slog.LogValue` to achieve the effect of formatting slices that are used as values in slog attributes, but only when we actually need to do so because a slog log line is being printed. Otherwise, `LogValue` is never called and we avoid the associated work and allocations.
brandur
force-pushed
the
brandur-slog-lazy-values
branch
from
September 7, 2025 12:37
c87d166 to
42bc65a
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple slice helpers to
slogutilthat implementslog.LogValueto achieve the effect of formatting slices that are used as values in
slog attributes, but only when we actually need to do so because a slog
log line is being printed. Otherwise,
LogValueis never called and weavoid the associated work and allocations.