Rust review sweep + runtime fixes, reconciled onto main#1468
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…emulation in v8 bridge
…d spawn through guest sh
…s through the kernel VFS
…s to spawned wasm children
…ad-only parent mounts
…nce a unique device id
…process.kill semantics
…ss.kill bridge errors
…up kill through the child_process polyfill
…verride, use vanilla Pi bash
…ng shell redirect visibility
…ig with metadata parsing
…t with classified inventory
…oring packages/core
…ns and serialize to vm metadata
…onstraints to CLAUDE.md
…stamp artifacts under packages/core
…/main (3-way resolve 33 hunks across 5 files)
…nd skip_os_instructions to CreateSessionRequest
…d assemble+inject system prompt at CreateSession
…kip instructions; stop assembling prompt host-side
…d from base layer
…ructions from agent descriptors
…pt; drop base-layer-bake assertions
…er that errors on non-flat node_modules (drop pnpm-hoisting resolver per review)
NathanFlurry
force-pushed
the
claude/rust-review-and-runtime-fixes
branch
from
5955345 to
37c45a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large branch landing the Rust Agent OS review/hardening sweep plus follow-up fixes, rebased and 3-way-merged onto current
main.What's in it
~/.agents/todo/agent-os-runtime-fixes.md): shell-mode exec routed through the VM/bin/sh -c(redirect emulation deleted), vanilla Pi bash via the unmodified SDK (process.kill pid/pgid semantics),VmLimitstyped limits config + classified inventory audit, and CLAUDE.md constraints (shell-grammar, Linux-semantics, locking/polling/parsing/jj-hygiene).Merge reconciliation onto main
maindiverged (origin added releases + node_modules + base-layer work). This branch was rebased onto it and the 33 true 3-way overlap hunks acrossagent_os.rs,session.rs,service.rs,tests/service.rs,execution.rswere resolved (union imports, audit-merge of same-fix duplicates picking the more-mature implementation, take-main for superseded code). Reconciliation is the finalmerge:commit.Reviewer attention (medium-confidence resolutions)
session.rs"superseded → main" hunks (our older code yields to origin's typed sidecar-binary-path plumbing).service.rs/agent_os.rssame-fix merges that dropped one side's now-unused fields/consts.Full per-hunk reasoning grouped by confidence:
~/.agents/reviews/agent-os-rust-revision-reviews-2026-06-12/merge-conflicts-to-review.md.OS_INSTRUCTIONS
Kept our
OS_INSTRUCTIONSconst + bootstrap write (no regression); origin's base-layer bake is left in place (redundant-but-safe, same fixture source). The proper "single-source, dynamic-from-tools, sidecar-owned, not-baked" redesign is tracked in~/.agents/todo/agent-os-os-instructions-sidecar-ownership.md.Verification (local)
cargo check,cargo clippy, andcargo test --test limits_auditall green onagent-os-{client,sidecar,v8-runtime,execution}. Full functional suite deferred to CI.🤖 Generated with Claude Code