fix: fix client leaked pipes#2474
Closed
MasterPtato wants to merge 1 commit into
Closed
Conversation
Contributor
Author
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses client pipe leaks by updating the nix crate dependency and improving pipe handling across the codebase.
- Updated workspace-level
nixdependency from v0.27 to v0.30 in/Cargo.tomlfor improved Unix system operations - Clarified pipe cleanup behavior in
/packages/edge/infra/client/manager/src/runner.rswith RAII guarantees - Standardized
nixdependency usage across packages by moving configuration to workspace level - Removed explicit feature flags for
nixin/packages/edge/services/pegboard/Cargo.tomlin favor of workspace defaults
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
147d554
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://03c8125d.rivet.pages.dev |
| Branch Preview URL: | https://05-26-fix-fix-client-leaked.rivet.pages.dev |
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
May 26, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Deploying rivet-studio with
|
| Latest commit: |
147d554
|
| Status: | ⚡️ Build in progress... |
This was referenced May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes