-
Notifications
You must be signed in to change notification settings - Fork 191
chore: expose namespace in otel attributes #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,6 +18,7 @@ ConditionPathExists=/etc/rivet-server/ | |||||
| Environment="RIVET_OTEL_ENABLED=1" | ||||||
| Environment="RIVET_OTEL_SAMPLER_RATIO=1" | ||||||
| Environment="RIVET_SERVICE_NAME=guard" | ||||||
| Environment="RIVET_NAMESPACE=__NAMESPACE__" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Template variable uses different underscore pattern than other environment variables (NAMESPACE vs CLUSTER_ID). Should be consistent with 3 underscores.
Suggested change
|
||||||
| Environment="RIVET_CLUSTER_ID=___CLUSTER_ID___" | ||||||
| Environment="RIVET_DATACENTER_ID=___DATACENTER_ID___" | ||||||
| Environment="RIVET_SERVER_ID=___SERVER_ID___" | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ ConditionPathExists=/etc/rivet-server/ | |
| Environment="RIVET_OTEL_ENABLED=1" | ||
| Environment="RIVET_OTEL_SAMPLER_RATIO=1" | ||
| Environment="RIVET_SERVICE_NAME=edge" | ||
| Environment="RIVET_NAMESPACE=__NAMESPACE__" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Ensure NAMESPACE is properly replaced during configuration. The template variable format differs from other environment variables which use ___ prefix/suffix. |
||
| Environment="RIVET_CLUSTER_ID=___CLUSTER_ID___" | ||
| Environment="RIVET_DATACENTER_ID=___DATACENTER_ID___" | ||
| Environment="RIVET_SERVER_ID=___SERVER_ID___" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ALTER TABLE service_logs ADD COLUMN namespace String DEFAULT ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Namespace field added at root level for pegboard logs, while metrics use .tags.namespace. Consider using consistent structure