Skip to content

chore(pegboard): add workaround fetching image size when not using ats #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanFlurry wants to merge 1 commit into from
Closed

chore(pegboard): add workaround fetching image size when not using ats #2744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/dev-full/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ services:
- RIVET_SERVICE_NAME=rivet-client
- RIVET_OTEL_ENDPOINT=http://otel-collector:4317
- RUST_LOG=debug,hyper=info
- __HACK__DISABLE_FETCH_IMAGE_SIZE=1
stop_grace_period: 0s
depends_on:
# HACK: rivet-server dependency since we need to do a DNS lookup in entrypoint.sh for the iptables chain
Expand Down
5 changes: 5 additions & 0 deletions packages/edge/infra/client/manager/src/image_download_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,11 @@ impl ImageDownloadHandler {
ctx: &Ctx,
image_config: &protocol::Image,
) -> Result<u64> {
// HEAD does not work if not using ATS
if std::env::var("__HACK__DISABLE_FETCH_IMAGE_SIZE").map_or(false, |x| x == "1") {
return Ok(0);
}

let addresses = self.get_image_addresses(ctx, image_config).await?;

let mut iter = addresses.into_iter();
Expand Down
Loading