Skip to content

feat(rivetkit): enable configuring manager host #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanFlurry wants to merge 1 commit into from
Closed

feat(rivetkit): enable configuring manager host #3969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rivetkit-typescript/packages/rivetkit/src/registry/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ export const RegistryConfigSchema = z
* What port to run the manager on.
*/
managerPort: z.number().optional().default(6420),
/**
* @experimental
*
* What host to bind the manager server to.
*/
managerHost: z.string().optional(),

/** @experimental */
inspector: InspectorConfigSchema,
Expand Down
14 changes: 9 additions & 5 deletions rivetkit-typescript/packages/rivetkit/src/registry/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ async function serveNode(

// Start server
const port = managerPort;
const server = serve({ fetch: app.fetch, port }, () =>
logger().info({ msg: "server listening", port }),
const hostname = config.managerHost;
const server = serve({ fetch: app.fetch, port, hostname }, () =>
logger().info({ msg: "server listening", port, hostname }),
);
injectWebSocket(server);

Expand Down Expand Up @@ -127,10 +128,11 @@ async function serveDeno(
}

const port = config.managerPort;
const hostname = config.managerHost;

// Use Deno.serve
Deno.serve({ port }, app.fetch);
logger().info({ msg: "server listening", port });
Deno.serve({ port, hostname }, app.fetch);
logger().info({ msg: "server listening", port, hostname });

return { upgradeWebSocket };
}
Expand Down Expand Up @@ -160,15 +162,17 @@ async function serveBun(
const { websocket, upgradeWebSocket } = createBunWebSocket();

const port = config.managerPort;
const hostname = config.managerHost;

// Use Bun.serve
// @ts-expect-error - Bun global
Bun.serve({
fetch: app.fetch,
port,
hostname,
websocket,
});
logger().info({ msg: "server listening", port });
logger().info({ msg: "server listening", port, hostname });

return { upgradeWebSocket };
}
Loading