Compare pages: premium redesign#5229
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
🚅 Deployed to the rivet-pr-5229 environment in rivet-frontend
|
4292df7 to
e84e4c7
Compare
Code Review: Compare Pages Premium RedesignOverviewThis PR applies a consistent premium visual treatment to the What looks good
Issues1. Arrow icon inconsistency
2. Status dot accessibility The status dot uses 3. Row hover state removed from comparison table The old rows had 4. Magic vertical offset on dot ( The 5. Using full paragraph text as a key works for static content but breaks silently if two identical paragraphs appear. Switching to Nits
SummaryClean redesign with solid component extraction. The two actionable items before merge are the status dot accessibility ( |
Compare Pages: Premium Redesign — Code ReviewOverviewThis PR redesigns the Positives
Issues1. Accessibility regression in The status dot only carries meaning through color and a <span className={`mt-[7px] h-1.5 w-1.5 flex-shrink-0 rounded-full ${dot}`} title={label} />
<span className={`mt-[7px] h-1.5 w-1.5 flex-shrink-0 rounded-full ${dot}`} aria-hidden="true" />
<span className="sr-only">{label}</span>2. PR scope includes an unrelated change (minor)
3. Arrow affordance inconsistency (minor)
<span aria-hidden="true" class="transition-transform group-hover:translate-x-0.5">→</span>
<Icon icon={faArrowRight} className="transition-transform group-hover:translate-x-0.5" />The hub and detail-page cards are visually identical use-cases and should use the same implementation. 4. Row hover feedback removed from comparison table (low) The previous Nits
|
38455e9 to
ab283d3
Compare
e84e4c7 to
26a2034
Compare

Redesigns the
/comparepages with the same premium treatment applied to the cookbook: generous whitespace, a consistent eyebrow + heading rhythm, hairline-only chrome, and restrained color.Changes
Detail pages (
/compare/<slug>/)text-lgsubtitle, primary + ghost CTA pair, and "Last updated" demoted to quiet metadata. Drops themin-h-[60vh]block that left the hero feeling empty.border-tseparators; rhythm comes from spacing and a shared heading lockup.bg-white/[0.03]), refined "When to choose" lists, and a quiet text-link CTA instead of a second button.Hub (
/compare/)text-lglede), cards restyled to the same rounded-xl hairline pattern.No data or copy changes; the page remains a zero-JS server render.
Verification
🤖 Generated with Claude Code