Conversation
Co-authored-by: RiX <9930448+rix1337@users.noreply.github.com>
|
@daddy-cool please have a look. I don't want to break our architectural pattern for a niche request. |
|
@Bartyboy please pull and test the new Docker:
Python:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06acc668dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return releases | ||
| search_string = html.unescape(search_string) | ||
| if season: | ||
| if season and episode_date is None: |
There was a problem hiding this comment.
When episode_date is present, season is the air-date year, but this condition sends date-numbered TV searches into the else branch that appends get_year(imdb_id) to the DD keyword. That makes DD query strings like Show 1996 for releases titled with the air date (for example Show.2026.06.19...), so those date-numbered episodes are likely missed before the new exact-date validation ever runs; keep the year suffix for movie/no-season searches only.
Useful? React with 👍 / 👎.
|
|
||
| @property | ||
| def supports_date_numbering(self) -> bool: | ||
| return True |
There was a problem hiding this comment.
I don't think this should default to True, sources that support it should explicitly define this instead
| timeout = SEARCH_REQUEST_TIMEOUT_SECONDS | ||
|
|
||
| if season: | ||
| if season and episode_date is None: |
There was a problem hiding this comment.
revert, NK does not support date searches
| timeout = SEARCH_REQUEST_TIMEOUT_SECONDS | ||
|
|
||
| if season: | ||
| if season and episode_date is None: |
There was a problem hiding this comment.
revert, HE could support date searches but this requires dedicated support
| + "'),", | ||
| " StringStruct(u'InternalName', u'Quasarr'),", | ||
| " StringStruct(u'LegalCopyright', u'Copyright © RiX'),", | ||
| " StringStruct(u'LegalCopyright', u'Copyright \\u00a9 RiX'),", |
|
I see a lot of "if season and episode_date is None:" and no other changes to sources, which causes these Sources to do only Season based searches in date-mode. This seems like a crude workaround to not get errors instead of adding proper date-mode support to these sources. This problem was already fixed in my original PR, where I cleared Reference for fix: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
ok, no problem. |
3 participants
What changed
MM/DDnumbering once into a validated sharedepisode_date.Why
PR #400 established date-numbered searching in DL, but left source-specific date fields and WWE-specific aliases. This follow-up makes date numbering a shared search capability without changing any source endpoint, HTTP method, parameter name, payload shape, or response parser.
Impact
episode_dateis absent.Verification
uv run python -X utf8 pre-commit.py: passed; 149 tests.uv run ruff check .: passed.uv run ruff format --check .: passed.main(c965cc5): 134 tests and Ruff passed in a detached worktree.mainand this branch: movie acceptance/rejection, exact/wrong TV episode, season pack, movie-as-TV rejection, document result, and episode-range acceptance/rejection.