Remove duplicate shrink engine handle lookup#6
Open
TianyeGGBond wants to merge 1 commit into
Open
Conversation
TianyeGGBond
force-pushed
the
tianye/f2-shrink-cleanup
branch
from
7667725 to
13bc53b
Compare
TianyeGGBond
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
RolloutManager.shrink_enginesbuilds the target engine handle list before closing router admission. The same handle list is still valid for the following abort/drain checks because the shrink path does not mutate engine handles between those steps.Summary
handles = [self._engines[idx].handle for idx in indices]lookup after_abort_engines(indices)Validation
python -m py_compile miles/ray/rollout.py