fix(miles): keep health checks in admission mode#7
Open
TianyeGGBond wants to merge 1 commit into
Open
Conversation
7fc79f1 to
56bf34a
Compare
56bf34a to
4059f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a narrow follow-up to the M11 router admission path.
In admission mode, an empty
enabled_workersset is a valid runtime state: the scheduler may have disabled/offloaded every registered worker, and generation requests should suspend until a worker is re-admitted.Before this change,
_health_check_loopusedif self.enabled_workersto decide whether admission mode was active. That makes an empty enabled set ambiguous:That fallback can fight the sleep/offload lifecycle because disabled workers are parked and should not be health-probed until they are re-admitted.
Change
_admission_declaredas the admission-mode switch in_health_check_loop.Validation
Passed:
python -m pytest tests/test_partial_sleep_wake.py::TestRouterAdmissionLifecycle -q # 4 passed, 1 warningPassed:
Also tried the whole file:
Local result is limited by unrelated missing heavy dependencies in this Windows environment:
ModuleNotFoundError: No module named 'ray'forTestEngineInfoStateMachineModuleNotFoundError: No module named 'torch'forTestSchedulerPreemptClassification