style(miles): move radix os import to module scope#9
Open
TianyeGGBond wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a small style cleanup for the RLix guard in
RadixTreeMiddleware.The code had a local import:
That comment is self-contradictory: it says the import belongs at module scope while keeping it local. There is also no practical reason to delay-import
os; it is a standard-library module, and the nearby RLix-mode call sites inrouter.pyandmulti_turn.pyalready use top-levelimport os.Change
osto the module import block.os.environdirectly in the RLix-mode guard.RLIX_CONTROL_PLANE=rlixstill rejectsRadixTreeMiddlewareinitialization.Validation
Passed:
Also ran a focused initialization check with temporary local import stubs for heavy optional dependencies missing in this Windows environment. With
RLIX_CONTROL_PLANE=rlix,RadixTreeMiddleware(...)still raises the expectedRuntimeError.